Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
d7415
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
SecurePathControllerto improve the handling of signed URL validation by separating signature expiration and validity checks, and simplifies thegetUrlmethod by removing unnecessary parameters and logic. Additionally, thehasCorrectSignaturemethod has been removed in favor of using Laravel's built-inhasValidSignaturemethod.Note that this new functionality relies ENTIRELY on a proper Nginx configuration.
Improvements to signed URL validation:
SecurePathControllerto first check for signature expiration usingsignatureHasNotExpiredand then validate the signature using Laravel'shasValidSignaturemethod. This improves clarity and leverages framework capabilities. (app/Http/Controllers/SecurePathController.php, app/Http/Controllers/SecurePathController.phpL36-L54)Simplification of URL generation:
getUrlmethod by removing the$absoluteparameter and redundant logic for handling query strings. The method now directly uses$request->url()combined with filtered query strings. (app/Http/Controllers/SecurePathController.php, app/Http/Controllers/SecurePathController.phpL75-R78)Code cleanup:
hasCorrectSignaturemethod, as its functionality is now replaced by Laravel'shasValidSignaturemethod, reducing duplication and improving maintainability. (app/Http/Controllers/SecurePathController.php, app/Http/Controllers/SecurePathController.phpL75-R78)